Skip to content

Remove access keyword from examples#288

Merged
maleadt merged 1 commit intoJuliaGPU:masterfrom
blegat:access
Mar 18, 2025
Merged

Remove access keyword from examples#288
maleadt merged 1 commit intoJuliaGPU:masterfrom
blegat:access

Conversation

@blegat
Copy link
Copy Markdown
Contributor

@blegat blegat commented Mar 17, 2025

Now that #264 is merged and released as part of 0.10.2, the examples need to be updated

@maleadt
Copy link
Copy Markdown
Member

maleadt commented Mar 18, 2025

LGTM. We could still support this for SVM-backed allocations, but I don't see this in the USM spec (only the sycl_ext_oneapi_usm_device_read_only extension).

@maleadt maleadt merged commit 55ab5b0 into JuliaGPU:master Mar 18, 2025
3 of 6 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.12%. Comparing base (bd6c0c5) to head (1401884).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   71.47%   73.12%   +1.65%     
==========================================
  Files          12       12              
  Lines         610      614       +4     
==========================================
+ Hits          436      449      +13     
+ Misses        174      165       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants