Skip to content

Conversation

@andrew-saydjari
Copy link
Contributor

@andrew-saydjari andrew-saydjari commented Apr 14, 2025

Adding CMasher

@andrew-saydjari
Copy link
Contributor Author

PR to address #142

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 50.75%. Comparing base (3693bff) to head (d250262).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/ColorSchemes.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
- Coverage   51.14%   50.75%   -0.39%     
==========================================
  Files           1        1              
  Lines         131      132       +1     
==========================================
  Hits           67       67              
- Misses         64       65       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrew-saydjari
Copy link
Contributor Author

@cormullion can you let me know if this attempt looks good? I would like to be able to see the preview of the docs that were built by the CI here to confirm that they were imported correctly.

Also, as you predicted, there were some naming collisions. Specifically

┌ Warning: skipping copper
┌ Warning: skipping fall
┌ Warning: skipping neon
┌ Warning: skipping ocean
┌ Warning: skipping watermelon

To avoid this, and because I like having uniformity, I just made all of the names "cmr_*" for the scheme names as found in the CMasher repo.

@cormullion
Copy link
Member

Don’t forget to import the new schemes:

function loadallschemes()

actually load cmasher.jl scheme
@cormullion cormullion merged commit fadad81 into JuliaGraphics:master Apr 14, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants