Skip to content

Secure AirspeedVelocity PR benchmark workflow - #517

Merged
Krastanov merged 1 commit into
JuliaGraphs:masterfrom
Krastanov-agent:secure-asv-benchmark-codex-20260723
Jul 23, 2026
Merged

Secure AirspeedVelocity PR benchmark workflow#517
Krastanov merged 1 commit into
JuliaGraphs:masterfrom
Krastanov-agent:secure-asv-benchmark-codex-20260723

Conversation

@Krastanov-agent

Copy link
Copy Markdown
Contributor

Summary

  • run the AirspeedVelocity benchmark workflow on pull_request instead of pull_request_target
  • keep the workflow token read-only with contents: read
  • write benchmark results to the job summary via job-summary: true instead of posting PR comments
  • keep the branch filter as [master, main] so this file can be reused across repos

This avoids the classic pull_request_target pwn request problem: the old workflow could execute PR-controlled benchmark/package code while holding base-repository privileges.

cc @Krastanov

Run AirspeedVelocity benchmarks on pull_request instead of pull_request_target so untrusted PR code does not execute with privileged base-repository permissions.

Write benchmark output to the job summary instead of PR comments, which lets the workflow token remain read-only.
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.46%. Comparing base (d153227) to head (63edb06).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         127      127           
  Lines        7766     7766           
=======================================
  Hits         7569     7569           
  Misses        197      197           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov

Copy link
Copy Markdown
Member

The previous version of the benchmark CI script was dangerous -- fixing this so that the runner can not be misused by external contributors.

@Krastanov
Krastanov merged commit 356aa72 into JuliaGraphs:master Jul 23, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants