Add support for parsing numbers as Int64 to JSONX #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
=======================================
Coverage 89.99% 89.99%
=======================================
Files 7 7
Lines 1329 1329
=======================================
Hits 1196 1196
Misses 133 133 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
(bump) |
quinnj
approved these changes
Oct 23, 2025
Member
quinnj
left a comment
quinnj
left a comment
There was a problem hiding this comment.
Sorry I forgot about this. This LGTM. While breaking, I think it's relatively minor and as you're the only known user of JSONX so far, we'll give you preference here ;)
I agree a changelog in this directory would probably be helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IJulia recently added a Python integration that involves passing parsed JSON to various Python libraries (JuliaLang/IJulia.jl#1190). Sometimes they can be picky about types, so this PR adds support for parsing as Int64 where possible. Also popped in a
@viewinparse_number()to reduce allocations.Unfortunately I'd say this is a breaking change. Don't think it makes sense to modify the JSON.jl version number, but we could keep a mini-changelog in the README?
Created with help from Claude 🤖