improve timeout and server error handling #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPCClient now reports back timeouts server errors via gRPC error codes. The `gRPCServiceCallException` struct has additional properties to hold the error code. When an error is encountered during a call that returns a single result (not stream), the call method now throws an exception instead of returning `nothing` as the result. Test suite to test error conditions added.
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 96.95% 95.57% -1.39%
==========================================
Files 5 5
Lines 230 271 +41
==========================================
+ Hits 223 259 +36
- Misses 7 12 +5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPCClient now reports back timeouts server errors via gRPC error codes. The
gRPCServiceCallExceptionstruct has additional properties to hold the error code.When an error is encountered during a call that returns a single result (not stream), the call method now throws an exception instead of returning
nothingas the result.Test suite to test error conditions added.