Skip to content

Conversation

@tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented May 3, 2021

updates to code generator to

  • allow additional include directories to be specified during code generation, which will be passed on to protoc.
  • handle . in package name

tanmaykm added 2 commits May 3, 2021 10:32
Allow additional include directories to be specified during code generation, which will be passed on to `protoc`.
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #11 (8d3cd75) into main (f8f2f68) will decrease coverage by 0.31%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   95.57%   95.25%   -0.32%     
==========================================
  Files           5        5              
  Lines         271      274       +3     
==========================================
+ Hits          259      261       +2     
- Misses         12       13       +1     
Impacted Files Coverage Δ
src/generate.jl 93.65% <77.77%> (-1.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f2f68...8d3cd75. Read the comment docs.

@tanmaykm tanmaykm merged commit 9f0529b into main May 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the tan/gen branch May 3, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants