set the TE header by default in requests #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some gRPC servers and proxies may need to be presented with a [`te` header](https://datatracker.ietf.org/doc/html/rfc7230#section-4.3). In gRPC trailers are always allowed in the protocol, but we encountered a scenario (#15) where the Python gRPC server implementation insists on it being [specified explicitly](https://nghttp2.org/blog/2015/03/24/proxying-grpc-with-nghttpx/). This PR sets the TE header to `trailers` by default in every request.
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 95.25% 95.27% +0.01%
==========================================
Files 5 5
Lines 274 275 +1
==========================================
+ Hits 261 262 +1
Misses 13 13
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gRPC servers and proxies may need to be presented with a
teheader. In gRPC trailers are always allowed in the protocol, but we encountered a scenario (#15) where the Python gRPC server implementation insists on it being specified explicitly.This PR sets the TE header to
trailersby default in every request.fixes #15