concurrent use is flaky, add to readme #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrent use of gRPCClient is flaky, particularly on Julia >= 1.7. The cause is unclear at this point. It could be something to do with libcurl, or the way we use libcurl, or something specific to the way libnghttp2 (that libcurl uses for HTTP2) works. For the time being, I am adding this as a TODO item, and moving the async tests under a flag.
Codecov Report
@@ Coverage Diff @@
## main #28 +/- ##
==========================================
- Coverage 95.55% 91.33% -4.23%
==========================================
Files 5 5
Lines 270 323 +53
==========================================
+ Hits 258 295 +37
- Misses 12 28 +16
Continue to review full report at Codecov.
|
Added an as of now experimental option to enable locking while using curl context concurrently. It can be switched on by passing `true` for the `enable_shared_locks` flag to gRPCController.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an as of now experimental option to enable locking while using
curl context concurrently. It can be switched on by passing
truefor the
enable_shared_locksflag to gRPCController.But concurrent use of gRPCClient is flaky, even with curl locks and
particularly on Julia >= 1.7. The cause is unclear at this point. It could
be something to do with libcurl, or the way we use libcurl, or something
specific to the way libnghttp2 (that libcurl uses for HTTP2) works.
For the time being, I am adding this as a TODO item, and moving the
async tests under a flag.