generate multiple services from single proto file #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single proto file may have multiple services defined. This change allows code generation of all services into the same module. Module is now named after the protobuf package instead of service.
tanmaykm
force-pushed
the
tan/gen
branch
2 times, most recently
from
aa87c4c to
f9507fd
Compare
Codecov Report
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 95.85% 95.95% +0.09%
==========================================
Files 4 4
Lines 169 173 +4
==========================================
+ Hits 162 166 +4
Misses 7 7
Continue to review full report at Codecov.
|
Allow ci failures on nightlies (because they mightbe unstable) and macos (because we often tun into rate limits on those).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single proto file may have multiple services defined.
This change allows code generation of all services into the same module.
Module is now named after the protobuf package instead of service.
Also updating CI config to allow failures on nightlies (because they could be unstable) and macos (because we often run into api rate limits with those).