code generation updates #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia protoc codegen looks for option `generic_services` to be turned on for at least one of `c++`, python or Java. I think that is unnecessary, but until it is updated, added a check here to check and warn. Also added instructions to readme. Package names with `.` are not handled well, needs some updates at protobuf code generation end. Have made the necessary changes needed here for now. And added instructions in readme to change package name to one without `.` before code generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia protoc codegen looks for option
generic_servicesto be turned on for at least one ofc++, python or Java. I think that is unnecessary, but until it is updated, added a check here to check and warn. Also added instructions to readme.Package names with
.are not handled well, needs some updates at protobuf code generation end. Have made the necessary changes needed here for now. And added instructions in readme to change package name to one without.before code generation.