Skip to content

Conversation

@tanmaykm
Copy link
Member

@tanmaykm tanmaykm commented Apr 7, 2021

Use updated ProtoBuf.jl that:

  • does not depend on service generation flags for other languages, removed corresponding checks here
  • allows service parameters that are nested message structs

Use updated ProtoBuf.jl that:
- does not depend on service generation flags for other languages
- allows service parameters that are nested message structs
@codecov-io
Copy link

codecov-io commented Apr 7, 2021

Codecov Report

Merging #7 (9e67593) into main (12c08f3) will increase coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   95.78%   96.95%   +1.16%     
==========================================
  Files           4        5       +1     
  Lines         190      230      +40     
==========================================
+ Hits          182      223      +41     
+ Misses          8        7       -1     
Impacted Files Coverage Δ
src/generate.jl 95.00% <ø> (+0.63%) ⬆️
src/grpc.jl 100.00% <0.00%> (ø)
src/gRPCClient.jl 100.00% <0.00%> (ø)
src/limitio.jl 100.00% <0.00%> (ø)
src/curl.jl 96.19% <0.00%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12c08f3...9e67593. Read the comment docs.

@tanmaykm tanmaykm merged commit cc7c233 into main Apr 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the tan/gen branch April 7, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants