Skip to content

Conversation

@musm
Copy link
Collaborator

@musm musm commented Aug 22, 2017

close #115

@musm
Copy link
Collaborator Author

musm commented Aug 24, 2017

any comments?

@musm musm requested a review from ChrisRackauckas August 25, 2017 01:14
@musm
Copy link
Collaborator Author

musm commented Aug 25, 2017

@ChrisRackauckas if it's annoying I can stop :)

@musm
Copy link
Collaborator Author

musm commented Aug 25, 2017

By that I mean always pinging you for review requests 😄

@ChrisRackauckas
Copy link
Member

No worries, it's fine. These are all simple. I don't know if I truly have "authority" to merge here though.

@musm
Copy link
Collaborator Author

musm commented Aug 25, 2017

Thanks, I just want to have another set of eyes on this, before I merge in a day or so.

@musm musm merged commit 348452a into JuliaInterop:master Aug 26, 2017
@musm musm deleted the err branch August 26, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better MEngineError error messages

2 participants