Skip to content

Better error for failed MEngine session #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2017
Merged

Better error for failed MEngine session #118

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d90999
Better error for failed MEngine session
musm Aug 22, 2017
94dd2a8
Improve warning
musm Aug 25, 2017
3a19d0c
Rm unnecessary newlines
musm Aug 25, 2017
2dd67eb
Update engine.jl
musm Aug 25, 2017
3cd891b
Update engine.jl
musm Aug 25, 2017
d71b4a5
Update engine.jl
musm Aug 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/engine.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,15 @@ mutable struct MSession

function MSession(bufsize::Integer = default_output_buffer_size)
ep = ccall(eng_open[], Ptr{Void}, (Ptr{UInt8},), default_startcmd)
ep == C_NULL && throw(MEngineError("failed to open a MATLAB engine session"))
if ep == C_NULL
Base.warn_once("Confirm MATLAB is installed and discoverable.")
if iswindows()
Base.warn_once("Ensure `matlab -regserver` has been run in a Command Prompt as Administrator.")
elseif islinux()
Base.warn_once("Ensure `csh` is installed; this may require running `sudo apt-get install csh`.")
end
throw(MEngineError("failed to open MATLAB engine session"))
end
# hide the MATLAB command window on Windows
iswindows() && ccall(eng_set_visible[], Cint, (Ptr{Void}, Cint), ep, 0)

Expand Down Expand Up @@ -54,7 +62,7 @@ end
function close(session::MSession)
# close a MATLAB Engine session
ret = ccall(eng_close[], Cint, (Ptr{Void},), session)
ret != 0 && throw(MEngineError("failed to close a MATLAB engine session (err = $ret)"))
ret != 0 && throw(MEngineError("failed to close MATLAB engine session (err = $ret)"))
session.ptr = C_NULL
return nothing
end
Expand Down Expand Up @@ -137,7 +145,7 @@ eval_string(stmt::String) = eval_string(get_default_msession(), stmt)
function put_variable(session::MSession, name::Symbol, v::MxArray)
# put a variable into a MATLAB engine session
ret = ccall(eng_put_variable[], Cint, (Ptr{Void}, Ptr{UInt8}, Ptr{Void}), session, string(name), v)
ret != 0 && throw(MEngineError("failed to put the variable $(name) into a MATLAB session (err = $ret)"))
ret != 0 && throw(MEngineError("failed to put variable $(name) into MATLAB session (err = $ret)"))
return nothing
end

Expand All @@ -148,7 +156,7 @@ put_variable(name::Symbol, v) = put_variable(get_default_msession(), name, v)

function get_mvariable(session::MSession, name::Symbol)
pv = ccall(eng_get_variable[], Ptr{Void}, (Ptr{Void}, Ptr{UInt8}), session, string(name))
pv == C_NULL && throw(MEngineError("failed to get the variable $(name) from a MATLAB session"))
pv == C_NULL && throw(MEngineError("failed to get variable $(name) from MATLAB session"))
return MxArray(pv)
end

Expand Down