Tweak to use mxChar in mxarray for String arguments #86
Conversation
|
Shouldn't |
|
|
||
| function mxarray(s::String) | ||
| utf16string = transcode(UInt16, s) | ||
| utf16string = transcode(mxChar, s) |
There was a problem hiding this comment.
Why? transcode is a julia function and not a MATLAB one so I don't see why this is better.
There was a problem hiding this comment.
we are marshalling it to matlab using _mx_create_char_array in the next line and matlab uses
http://www.mathworks.com/help/matlab/apiref/mxchar.html
also thread: #76
There was a problem hiding this comment.
transcode(UInt16, ...) is the API to decode it as UTF16, not transcode(mxChar, ...). I don't see how any of the links are relevant.
There was a problem hiding this comment.
typealias mxChar UInt16 at the top
There was a problem hiding this comment.
Right.
- They are the same so why change it?
- You are calling julia API defined on
UInt16and documented as so and why confuse the reader about what you are calling using an matlab type alias?
There was a problem hiding this comment.
Ok if you feel that way close this and let's move on. I just want to move on and not create a big issue. I just felt that this was more consistent since it's used below https://github.com/musm/MATLAB.jl/blob/6993d1e50f38ae73ec45a0bf7a4bbe64ac4058ca/src/mxarray.jl#L646
to convert the String back to Julia.
2 participants
No description provided.