remove zero length memory boundscheck for memoryrefget/set#62070
Open
oscardssmith wants to merge 3 commits into
Open
remove zero length memory boundscheck for memoryrefget/set#62070oscardssmith wants to merge 3 commits into
oscardssmith wants to merge 3 commits into
Conversation
oscardssmith
added
arrays
oscardssmith
marked this pull request as ready for review
June 11, 2026 16:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than emitting code for a length check on memoryref, we can ensure that all zero length memories have their ptr field point to a guard page so that reads of the page will fault.
This lets us do the boundschecking for Vector/Memory operations purely on the codegen side rather than on the julia side which reduces the amount of Julia IR for functions that do lots of array manipulation. It also may give slightly better codegen as we are doing a slightly simpler boundscheck.
Coauthored by Fable 5