DArray: Add LU, triangular solve, and more#675
Merged
Conversation
jpsamaroo
force-pushed
the
jps/lu-ldiv3
branch
from
50d9d94 to
a999860
Compare
- **Implemented RowMaximum Pivoting**: Added a new LU factorization strategy using the RowMaximum pivoting method for distributed matrices - **Custom Pivot Search and Swapping**: Introduced helper functions for searching row maxima, updating pivot indices, and swapping rows in both panel and trailing submatrices - **Blockwise Distributed Algorithm**: Ensured compatibility with block-partitioned distributed matrices, supporting only equal block sizes for now - **Non-breaking Addition**: Existing NoPivot LU functionality remains unchanged; RowMaximum is an additional strategy selectable via the LinearAlgebra interface.
jpsamaroo
force-pushed
the
jps/lu-ldiv3
branch
from
515d73e to
c8ff89f
Compare
Member
Author
|
@AkhilAkkapelli thanks so much for your hard work and patience on these algorithms! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @AkhilAkkapelli for the implementations! He implemented these a while back, but I had blocked merging them on #662 as they use views in Datadeps (which were broken until that PR).
This also fixes some bugs in Datadeps and improves various bits and pieces of the DArray that LinearAlgebra routines utilize.
Partially written by Claude (bug fixes, tests, etc.)
Todo:
SingularExceptionin LU testsldiv!ldiv!support to docs