Allow J_a_fluence on non-uniform time grids#108
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #108 +/- ##
========================================
+ Coverage 87.7% 87.7% +0.1%
========================================
Files 20 20
Lines 1124 1128 +4
========================================
+ Hits 985 989 +4
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the pulse-fluence running cost to handle non-uniform time grids, aligning J_a_fluence and its analytic gradient with interval-dependent dt_n weights rather than a single uniform timestep.
Changes:
- Reworked
J_a_fluenceandgrad_J_a_fluenceto weight each interval bydiff(tlist). - Expanded the
J_a_fluence/make_grad_J_adocs to describe the pulse vectorization layout and non-uniform-grid behavior. - Added a regression test covering a non-uniform
tlistand validating the analytic and Zygote gradients.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/functionals.jl |
Implements non-uniform timestep weighting in the fluence functional and updates related documentation. |
test/test_functionals.jl |
Adds regression coverage for non-uniform grids and checks the analytic/Zygote gradient results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goerz
force-pushed
the
J-a-fluence-non-uniform
branch
from
May 4, 2026 19:31
a4dcac8 to
894696b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.