Skip to content

Allow J_a_fluence on non-uniform time grids#108

Merged
goerz merged 1 commit into
masterfrom
J-a-fluence-non-uniform
May 4, 2026
Merged

Allow J_a_fluence on non-uniform time grids#108
goerz merged 1 commit into
masterfrom
J-a-fluence-non-uniform

Conversation

@goerz

@goerz goerz commented May 4, 2026

Copy link
Copy Markdown
Member

No description provided.

@goerz goerz added the enhancement New feature or request label May 4, 2026
@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.7%. Comparing base (5d4e99f) to head (894696b).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #108     +/-   ##
========================================
+ Coverage    87.7%   87.7%   +0.1%     
========================================
  Files          20      20             
  Lines        1124    1128      +4     
========================================
+ Hits          985     989      +4     
  Misses        139     139             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the pulse-fluence running cost to handle non-uniform time grids, aligning J_a_fluence and its analytic gradient with interval-dependent dt_n weights rather than a single uniform timestep.

Changes:

  • Reworked J_a_fluence and grad_J_a_fluence to weight each interval by diff(tlist).
  • Expanded the J_a_fluence/make_grad_J_a docs to describe the pulse vectorization layout and non-uniform-grid behavior.
  • Added a regression test covering a non-uniform tlist and validating the analytic and Zygote gradients.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/functionals.jl Implements non-uniform timestep weighting in the fluence functional and updates related documentation.
test/test_functionals.jl Adds regression coverage for non-uniform grids and checks the analytic/Zygote gradient results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/functionals.jl
Comment thread test/test_functionals.jl
@goerz
goerz force-pushed the J-a-fluence-non-uniform branch from a4dcac8 to 894696b Compare May 4, 2026 19:31
@goerz
goerz merged commit 493f59a into master May 4, 2026
8 checks passed
@goerz
goerz deleted the J-a-fluence-non-uniform branch May 4, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants