Skip to content

Fix some errors in demos #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Fix some errors in demos #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/demo-fh.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using LinearAlgebra
using DifferentialEquations, ProximalOperators
using ADNLPModels, NLPModels, NLPModelsModifiers, RegularizedOptimization, RegularizedProblems

Expand Down
5 changes: 0 additions & 5 deletions examples/demo-nnmf-constr.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,6 @@ function demo_solver(f, h, χ, selected, Avec, m, n, k, suffix = "l0-linf")
R2_out = R2(f, h, options, selected = selected)
plot_nnmf(R2_out, Avec, m, n, k, "r2-$suffix")

@info " using TR with R2 as subproblem to solve with" h χ
reset!(f)
TR_out = TR(f, h, χ, options, selected = selected)
plot_nnmf(TR_out, Avec, m, n, k, "tr-r2-$suffix")

Copy link
Member

@dpo dpo Jun 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for removing these lines?

Copy link
Member Author

@geoffroyleconte geoffroyleconte Jun 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are already written a few line above. I must have done a wrong copy/paste when adding this demo.

subsolver_options = ROSolverOptions(spectral = false, psb = true, ϵa = options.ϵa)
@info " using TR with TRDH as subproblem to solve with" h χ
reset!(f)
Expand Down