Throw documented ArgumentError for unknown serial test names - #158
Merged
Conversation
`runtests` filtered the `serial` list down to testsuite keys before `partition_tests` could validate it, so the ArgumentError promised by the docstring was unreachable through the public API: a typo'd serial name was silently dropped and the misspelled test ran in parallel — exactly the hazard the `serial` option exists to prevent. Validate the serial names against the full testsuite before command-line filtering, so typos throw while names legitimately deselected by positional arguments are still ignored. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.