Couple of bug fixes related to the status printing - #161
Merged
Conversation
The status line listing running tests was truncated by slicing with byte indices after checking the character length, so a multi-byte character straddling the cut point threw a StringIndexError. This killed the printer task, which then surfaced as a TaskFailedException from finalization — and the truncation is computed even when stdout is not a TTY, so CI runs with long non-ASCII test names were exposed too. Extract the truncation into a `truncate_line` helper that slices by character, and unit-test it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
In verbose mode, `print_test_failed` wrote the init-time cell to `ctx.stdout` while every other part of the row went to `ctx.stderr`, splitting a single row across the two streams when they are redirected separately. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.