Run HTTP server tasks on the interactive thread pool - #1344
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
+ Coverage 88.38% 88.44% +0.06%
==========================================
Files 30 31 +1
Lines 11923 11930 +7
==========================================
+ Hits 10538 10552 +14
+ Misses 1385 1378 -7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Preserve the existing task error behavior while selecting the interactive pool. Wrapping server tasks in errormonitor pulls Base error-display I/O into JuliaC strict trim compilation on Julia 1.13 and produces unresolved dynamic calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:interactivethread poolWhy
Reseau's foreign thread performs readiness polling. It does not execute Julia request or handler tasks. HTTP.jl v2 had moved the server task tree to the default pool, so non-yielding default-pool compute could still prevent health checks and other HTTP work from running.
This restores the isolation that HTTP.jl v1 provided. The scheduling choice is intentional and is not configurable. If no interactive thread exists, Julia falls back to the default pool.
Fixes #1342.
Validation
--threads=2,1git diff --checkCo-authored by Codex