This repository was archived by the owner on May 17, 2019. It is now read-only.
include Julia 0.5 in tests, remove depwarns - #142
Merged
Merged
Conversation
tanmaykm
commented
Dec 7, 2016
tanmaykm
commented
Member
- include Julia 0.5 in travis tests
- remove depwarns
quinnj
reviewed
Dec 7, 2016
| if VERSION >= v"0.5.0-dev+4817" | ||
| import Base: view | ||
| end | ||
|
|
Member
Author
There was a problem hiding this comment.
There is this in Compat:
if !isdefined(Base, :view)
const view = slice
end
But isn't import is still required, since Requests also defines view?
Current coverage is 71.56% (diff: 100%)@@ master #142 diff @@
==========================================
Files 4 4
Lines 514 517 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 364 370 +6
+ Misses 150 147 -3
Partials 0 0
|
quinnj
reviewed
Dec 7, 2016
| if VERSION < v"0.5.0-dev+4817" | ||
| write(stream,sub(file.data,(position(file)+1):(position(file)+nb_available(file)))) | ||
| else | ||
| write(stream,view(file.data,(position(file)+1):(position(file)+nb_available(file)))) |
Member
There was a problem hiding this comment.
You can just say Base.view here instead. The view definition in Requests isn't meant to be exported anyway. Then we can get rid of the import above.
Member
Author
|
@quinnj review comments incorporated |
quinnj
approved these changes
Dec 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.