fix massege box with non ascii carecters - #120
Merged
Merged
Conversation
Owner
|
@naattxx thanks for the fix! 🙂 The root cause is exactly right, but please don't pull in Node.js modules here: the app runs on GJS, not Node.js, and node:buffer would just bloat the bundle (even though it is still possible to use Node.js modules with GJSify). The fix works without any dependency, just pass -1 and GTK figures out the byte length itself: Could you change that and revert the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #119 using
Buffer.byteLength(str, 'utf8')