Gnome: equalize d-pad cell widths - #137
Merged
Merged
Conversation
The empty center filler keeps the default button padding (10px per side) instead of the 5px the surrounding icon buttons get from libadwaita's .image-button rule. Combined with osd's 32px min-width that pushed its minimum width to 52px, overruling the shared 50px width-request and offsetting the up/down buttons by 1px per side. Give the filler the icon buttons' padding so every cell is 50px. Fixes #136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The up/down d-pad buttons were 2px narrower than the center box (1px offset per side), see #136.
Cause: All d-pad buttons share
width-request: 50. The icon buttons get 5px horizontal padding from libadwaita's.image-buttonrule, so their CSS minimum (32px osdmin-width+ 10px) stays below the width-request. The empty center filler is not an image button and keeps the default 10px-per-side padding, pushing its minimum width to 52px — overruling the width-request. Withhalign: center, the 50px up/down buttons floated centered inside the 52px column.Fix: Give the center filler the same horizontal padding as the icon buttons via a new
gamepad.css, so every cell is exactly 50px.Verification
Ran the app and pixel-analyzed a screenshot of the d-pad: up, center, and down cells now all span the same 50px (previously the center was 52px wide); all seams are flush, including the left/right button rows.
Fixes #136