[Fix] Remove unused context parameters from tab pages#316
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Remove Xunfei STT/PCM imports from App.tsx (moved to useXunfeiStt.ts in PR #315) - Remove unused setThemeLocal, settingsLoading, authSubmitting - Remove unused context params from home.tsx (selectScenario etc. consumed internally by HomeScreen) - Remove unused api param from settings.tsx (created internally by SettingsScreen) - Add block-level eslint-disable for react-hooks/exhaustive-deps in AppInner Closes #314
JunchenMeteor
force-pushed
the
dev/fix/unused-context-params
branch
from
June 20, 2026 16:50
4a45499 to
04ad2ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After PR #315 (expo-router migration), lint reported unused imports and context parameters in tab pages and App.tsx.
Changes
Test Plan
Closes #317