Skip to content

fix: fix the notorious bearer token issue#25

Closed
TiansuYu wants to merge 1 commit intoJupiterOne:mainfrom
TiansuYu:fix-bearer-token
Closed

fix: fix the notorious bearer token issue#25
TiansuYu wants to merge 1 commit intoJupiterOne:mainfrom
TiansuYu:fix-bearer-token

Conversation

@TiansuYu
Copy link

Up to this point, this lib does not really work, every time one makes query_v1 requests, it just breaks with the following error:

jupiterone.errors.JupiterOneApiError: 403:'xxx' not a valid key=value pair (missing equal-sign) in Authorization header: 'Bearer xxx'.

After some discovery, it is actually this missing path that is causing the problem. Please update this so we can continue using lib>=1.0

@TiansuYu TiansuYu requested review from a team as code owners August 22, 2024 16:44
@TiansuYu
Copy link
Author

Also, please have proper tests in place

@SeaBlooms
Copy link

the query_endpoint should indeed be "https://graphql.us.jupiterone.io" - /graphql on the end is not correct

I've updated the docs to call out the .us vs .eu URL needed

1.0.0 and 1.0.1 are both fully functional.

@TiansuYu
Copy link
Author

I have tested it at Klarna, https://graphql.us.jupiterone.io/ only works with /graphql. Without it, the lib is in a broken state for us.

@SeaBlooms
Copy link

SeaBlooms commented Aug 22, 2024

@TiansuYu
Copy link
Author

Sorry, my bad, somewhere in the lib, I have pinned the base url to the old one, thats the problem. Thanks for the feedback!

@TiansuYu TiansuYu closed this Aug 22, 2024
@TiansuYu TiansuYu deleted the fix-bearer-token branch August 22, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants