Skip to content

fix: bound websocket queue overrides - #287

Draft
Justinabox wants to merge 1 commit into
mainfrom
agent/ws-queue-bounds-20260728
Draft

fix: bound websocket queue overrides#287
Justinabox wants to merge 1 commit into
mainfrom
agent/ws-queue-bounds-20260728

Conversation

@Justinabox

Copy link
Copy Markdown
Owner

Summary

  • validate callstack_ws_queue_size as a non-boolean positive integer before the WebSocket upgrade, subscription, or queue construction
  • preserve the default bounded queue size of 32 and honor valid positive overrides
  • add resolver, invalid-override endpoint, and endpoint queue-construction regression coverage

Closes #286

Verification

  • git diff --check
  • PYTHONPATH=. uv run --no-project --with pytest --with pytest-asyncio --with pytest-aiohttp --with pyserial-asyncio --with aiosqlite pytest tests/test_websocket.py -q → 36 passed
  • PYTHONPATH=. uv run --no-project --with pytest --with pytest-asyncio --with pytest-aiohttp --with pyserial-asyncio --with aiosqlite pytest tests/ -q → 1120 passed

Risks

Invalid in-process app overrides now fail before a WebSocket connection is prepared; the existing application has no public configuration surface for this internal override. Valid overrides retain the existing drop-oldest, PII-safe overflow behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reject unbounded WebSocket queue-size overrides

1 participant