fix: reject malformed SMS deliver timestamps - #291
Draft
Justinabox wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
Release review: needs-fix before landing. The targeted malformed-calendar SCTS guard is correct, but timestamp parsing remains permissive for invalid timezone semi-octet BCD. For example, timezone byte Please validate BCD digits after removing the timezone sign bit, then add both direct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #290.
Verification
git diff --checkPYTHONPATH=. uv run --no-project --with pytest --with pytest-asyncio --with pyserial-asyncio pytest tests/test_sms_pdu.py -q— 59 passedPYTHONPATH=. uv run --no-project --with pytest --with pytest-asyncio --with pytest-aiohttp --with pyserial-asyncio --with aiosqlite pytest tests/ -q— 1094 passedRisk
Malformed SMS-DELIVER frames with missing/invalid timestamps now fail closed rather than returning a message without a timestamp. Valid numeric and alphanumeric PDU regression coverage remains green.