fix(discordsh-e2e): open sign-in modal before asserting OAuth button class#7976
Merged
fix(discordsh-e2e): open sign-in modal before asserting OAuth button class#7976
Conversation
…class The nb-oauth-discord button is inside a conditionally-rendered React modal (client:only="react"). The previous test checked page.content() after domcontentloaded, but the modal DOM doesn't exist until the user opens it. Now waits for React hydration, clicks the Sign in button to open the modal, then asserts the Discord OAuth button has the correct CSS classes.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuth buttons use nb-oauth-btn classe2e testnb-oauth-discordbutton lives inside a conditionally-rendered React modal (client:only="react") — it doesn't exist in the DOM until the user opens itpage.content()afterdomcontentloaded, which only has the SSR shell (no React output)Test plan
e2e:docker discordsh-e2epasses all 44 tests (43 previously passing + this fix)