feat(rows): seed/biome in zone assignment + allocation race fix#9250
Merged
feat(rows): seed/biome in zone assignment + allocation race fix#9250
Conversation
1. Wire seed + biome through GetZoneAssignment response - ZoneAssignment model: seed (i64, default 0), biome (Option<String>) - REST response includes seed + biome fields - Foundation for procedural world generation (FastNoise) 2. Wire seed + biome through MQ SpinUpMessage - Server receives seed in spin-up message for ServerTravel URL option - TODO stubs for maps table seed lookup 3. Allocation pipeline race condition fix - On failure: clean up stale DB entries (mapinstances + worldservers) - Release spinup lock - Log allocation_failed event for dashboard visibility - Prevents orphaned DB entries when GS dies mid-allocation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
seed(i64) +biome(optional string) through GetZoneAssignment response and MQ SpinUpMessageFastNoise foundation
seed: 0= handcrafted map (current behavior)seed: N= procedural world (future, after DB migration adds seed column to maps table)ServerTravel("...?seed=N")