fix(chisel): add make to builder image for jemalloc builds#9579
Merged
Conversation
tikv-jemalloc-sys builds jemalloc from source via autoconf/make. The chisel builder was missing make, causing all services with --features jemalloc to fail with "No such file or directory".
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
h0lybyte
added a commit
that referenced
this pull request
Apr 3, 2026
…loc-enabled Dockerfiles The published chisel-ubuntu-axum:24.04-builder image on GHCR is missing make despite the Dockerfile being updated in #9579. This causes tikv-jemalloc-sys build.rs to panic with ENOENT when running make after configure completes. Add a defensive dpkg check + conditional apt install of make in the builder stage of all 8 Dockerfiles that use --features jemalloc. The guard is a no-op once the base image is republished with make. Closes #9596
2 tasks
h0lybyte
added a commit
that referenced
this pull request
Apr 3, 2026
…loc-enabled Dockerfiles (#9604) The published chisel-ubuntu-axum:24.04-builder image on GHCR is missing make despite the Dockerfile being updated in #9579. This causes tikv-jemalloc-sys build.rs to panic with ENOENT when running make after configure completes. Add a defensive dpkg check + conditional apt install of make in the builder stage of all 8 Dockerfiles that use --features jemalloc. The guard is a no-op once the base image is republished with make. Closes #9596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maketo chisel builderapt-get install— required bytikv-jemalloc-sysbuild script24.04.6→24.04.7to trigger rebuildAll 7 Rust services are currently failing because the builder image lacks
make.Closes #9558
Test plan
--features jemalloc