fix(firecracker-ctl): add sccache mount for chisel builder compatibility#9581
Merged
fix(firecracker-ctl): add sccache mount for chisel builder compatibility#9581
Conversation
The chisel builder image has RUSTC_WRAPPER=sccache baked in. Without an sccache cache mount, cargo metadata fails at the planner stage. Add --mount=type=cache,target=/usr/local/sccache,id=sccache to all cargo steps and ENV CARGO_INCREMENTAL=0, matching other Axum services.
h0lybyte
force-pushed
the
trunk/fix-fc-docker3-1775241437
branch
from
9a68899 to
641f15d
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
--mount=type=cache,target=/usr/local/sccache,id=sccacheto all cargo steps andENV CARGO_INCREMENTAL=0to build stages, matching all other Axum services.Root cause
The chisel builder image (
ghcr.io/kbve/chisel-ubuntu-axum:24.04-builder) hasRUSTC_WRAPPER=sccachebaked in. Without an sccache cache mount target,cargo metadata(called bycargo chef prepare) fails because sccache can't write its cache. The other Axum Dockerfiles all include this mount — firecracker-ctl was missing it.Fixes #9571
Test plan