Make the file-lock timing check deterministic - #286
Conversation
|
Reviewer note: The original test started the timer after the child process launch. Child startup time then consumed part of the 50 ms assertion margin. This change starts the timer before the launch. It does not change the lock implementation or weaken the strict Evidence:
|
cukas
left a comment
There was a problem hiding this comment.
Verified independently: ran the file-lock suite at this ref in a clean worktree — 14 passed / 1 skipped. Starting the clock before the child launch can only widen waited, so the strict > staleMs assertion only gets safer, and the lock implementation is untouched. Approving first per your merge order — the CI red on #281/#282 traces back to this flake.
|
LGTM. The current head is green and has formal maintainer approval. The change removes child startup time from the assertion margin without changing the lock implementation or weakening the strict timing assertion. |
Summary
waited > staleMsassertionVerification
npm run kern:compilenpm run typechecknpm run buildnpm run test: 306 files passed, 4,612 tests passed, 6 skippedCloses #284