Skip to content

Read the installed game version from KSA.dll - #57

Merged
MrJeranimo merged 4 commits into
mainfrom
installed-game-version
Sep 3, 2026
Merged

Read the installed game version from KSA.dll#57
MrJeranimo merged 4 commits into
mainfrom
installed-game-version

Conversation

@Maximilian-Nesslauer

Copy link
Copy Markdown
Member

Closes #38.

Borea could not tell which game build is installed, so nothing could answer whether a mod fits it.

InstalledGameVersionProvider reads the version resource of KSA.dll, the first two steps of RFC 0017's chain. The Content/Versions fallback still needs to be done as a follow-up.

Four ways to have no answer all return null if the game location is unknown, the file is not there, it is not a PE, or it carries no version resource.

The tests need real version resources, so two fixture projects build assemblies that carry nothing else, and a test copies one in under the game's file name.

No caller acts on it yet. It feeds #55, where installed?.Version reaches Compatibility.Evaluate with no adapter and both null paths land on Unknown.

@Maximilian-Nesslauer Maximilian-Nesslauer added this to the RFC alignment milestone Aug 31, 2026
@Maximilian-Nesslauer Maximilian-Nesslauer added area:core Borea.Core, the domain model area:storage Borea.Storage, persistence and TOML labels Aug 31, 2026
@Maximilian-Nesslauer Maximilian-Nesslauer added the area:storage Borea.Storage, persistence and TOML label Aug 31, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Borea Aug 31, 2026
@coveralls

coveralls commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 33703589041

Coverage increased (+0.04%) to 90.27%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 19 of 19 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1906
Covered Lines: 1763
Line Coverage: 92.5%
Relevant Branches: 951
Covered Branches: 816
Branch Coverage: 85.8%
Branches in Coverage %: Yes
Coverage Strength: 42.51 hits per line

💛 - Coveralls

@MrJeranimo
MrJeranimo merged commit ed1257e into main Sep 3, 2026
6 checks passed
@MrJeranimo
MrJeranimo deleted the installed-game-version branch September 3, 2026 01:38
@github-project-automation github-project-automation Bot moved this from In review to Done in Borea Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Borea.Core, the domain model area:storage Borea.Storage, persistence and TOML

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Read the installed game version from KSA.dll's version resource

3 participants