Reset countdown at midnight after overtime - #37
Merged
Conversation
Leaving the machine on past midnight after overtime parked the daemon in :done, so the next day's shutdown was never enforced. Arm a midnight timer that resets to severance mode and waiting, reschedules the countdown, and re-arms itself.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0680e68086
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The reset timer waits monotonic milliseconds, but the interval to the next midnight is wall-clock, so a DST transition fires it up to an hour off. Track the session's local date and only roll over once the date has actually advanced; an early fire just re-arms, which re-reads the clock and self-corrects.
The day-rollover decision lived inside the GenServer callback and read the clock through the now_fn injection, forcing tests to override it. Move it into a pure reset_state/2 that takes the current day as an argument, so the rollover and DST early-fire cases test directly without dependency injection.
…me is a single-day opt-out and the next day's shutdown is enforced again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Countdowndaemon in:done— the next day's shutdown was never enforced.mode: :severance,phase: :waiting), reschedules the countdown start, and re-arms itself for the following midnight.ms_until_midnight/1for the timer math (with doctest) and document the reset in the README Overtime Protocol section.Test plan
mix test test/severance/countdown_test.exs— new tests cover reset-to-waiting, reschedule-into-countdown, andms_until_midnight/1mix quality— format, compile, credo, dialyzer, doctor, tests + coverage all pass