fix: Fix JSON serialization error of ApiModel in print_obj#1040
Merged
Conversation
Contributor
|
/gcbrun |
stevemessick
self-requested a review
June 1, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running model-related CLI commands such as:
The command fails with the following traceback:
This error occurs because the
kaggle_api_extended.pyhelper method inkaggle_api_extended.pyattempts to pass raw generated models (such asApiModelandApiModelInstance) directly tojson.dumps().kaggle-cli/src/kaggle/api/kaggle_api_extended.py
Lines 5898 to 5900 in 4fc2429
Solution
Updated the
kaggle_api_extended.pyhelper method to call.to_dict()on the object before serialization:Affected Commands
This resolves crashes in the following CLI commands (when running without the
-p/--pathoption):kaggle models get <model>(via kaggle_api_extended.py)kaggle models instances get <model_instance>(via kaggle_api_extended.py)Both
ApiModelandApiModelInstanceimplement.to_dict(), allowing the standardjson.dumpslibrary to successfully serialize the resulting dict format.