Skip to content

All - Tank designer company cost reduction bonus should apply to flame and amphibious tanks #22148

Description

@popodaet

Quick questions
OS: Windows 11
HOI4 version: 1.12.11
Kaiserreich version: 0.24.2
List any other mods used: KR music mods, KR model mods, show speed in construction view
Were you using Steam? Yes
Were you in multiplayer? No
Which expansions do you NOT have? None

Explanation of the issue:
Tank Designer companies (150 pp ones) do not apply cost reduction bonus to flame and amphibious tank of respective sizes.

Steps to reproduce:

  1. Enter fresh game as Germany, grant political power and select Krupp for medium tank cost reduction.
  2. Grant yourself army xp and research stuff so you can design medium amphibious and flame tanks
  3. Design another anti-air, observe anti-air has Krupp bonus but medium amphibious/flame tanks don't

Possible cause:
In common/country_leader/company.txt, traits like medium_tank_producer_mass_2 don't apply equipment bonus to the flame and amphibious medium tanks. Same goes for all light, medium, heavy and company strengths 0, 1, and 2.

For example, 0.24.2 code

	medium_tank_producer_mass_2 = {
		random = no
		equipment_bonus = {
			medium_tank_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_artillery_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_destroyer_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_aa_chassis = {
				build_cost_ic = -0.15
			}
		}

		ai_will_do = { factor = 1 }
	}

fixed code:

	medium_tank_producer_mass_2 = {
		random = no
		equipment_bonus = {
			medium_tank_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_artillery_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_destroyer_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_aa_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_amphibious_chassis = {
				build_cost_ic = -0.15
			}
			medium_tank_flame_chassis = {
				build_cost_ic = -0.15
			}
		}

		ai_will_do = { factor = 1 }
	}

These names are from vanilla common/units/equipment/x_tank_chassis.txt, which KR does not replace. Modern and Superheavies don't have amphibious and flame variants, so we don't need to worry about those.

Screenshots:
image

Metadata

Metadata

Assignees

Labels

BugIt's a bug!

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions