Improve poster display and keyboard handling across screens#186
Merged
Conversation
Grid cells were sized to each item's native aspect ratio (16:9 for landscape stills and video thumbnails, 2:3 for posters), and audiobook covers had no handling so their square art was cropped into the 2:3 box. Every cell now uses the uniform 2:3 poster box. The art is drawn with contentFit "contain" so it is never cropped, and a blurred, cover-scaled copy of the same image fills the surrounding letterbox area instead of flat empty bars. This applies to landscape thumbnails and square audiobook covers alike; portrait posters cover the box exactly and hide the backdrop. Removes the now-unused posterIsLandscape plumbing and the getEpisodePosterIsLandscape helper. Fixes #175 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017gfyJkR4WmDdEjpXhk1pFC
None of the screens with TextInputs (Settings, Edit Item, First Time Setup, and the drawer's password modal) had any keyboard-avoidance handling, so focusing a field near the bottom of a ScrollView — or the password modal, which renders in its own native layer outside any screen-level handling — could leave it hidden behind the on-screen keyboard. Wrap each of these in a KeyboardAvoidingView (padding on iOS; Android already resizes the window via Expo's default adjustResize windowSoftInputMode, so no behavior is needed there — except inside the Modal, which doesn't reliably inherit that resize and needs an explicit "height" behavior). Fixes #185 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017gfyJkR4WmDdEjpXhk1pFC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes two main improvements to the app:
Key Changes
PosterBox Component Refactoring
posterIsLandscapeproperty from PosterBoxItem type—the component now automatically handles all image aspect ratiosviewOrientationprop dependency, simplifying the component interfaceBACKDROP_BLUR_RADIUSconstant (24) for consistent visual stylingthumbnailHeightfor all itemsMediaBrowserScreen Updates
posterIsLandscapefield from DisplayItem type definitionsgetEpisodePosterIsLandscape()helper functionviewOrientationprop when rendering PosterBox componentsKeyboard Handling Improvements
All keyboard-avoiding views use
behavior={Platform.OS === 'ios' ? 'padding' : undefined}to provide appropriate spacing on iOS while avoiding layout issues on Android.Implementation Details
blurRadiusprop for native performancehttps://claude.ai/code/session_017gfyJkR4WmDdEjpXhk1pFC