Fix pyproject.toml for the final release of bdpy supporting Python 3.6–3.8#112
Conversation
ganow
left a comment
There was a problem hiding this comment.
I've briefly reviewed the PR and added comments. Could you please make revisions based on these comments? I haven't actually tested the proposed changes myself, so please verify whether they work as expected.
|
I fixed code based on your comment and I think all the pytest passed. |
|
@HirokiYasuda03 Sorry for not seeing this PR for a long time. Could you please change the following section of [tool.rye]
managed = true
dev-dependencies = [
"bdpy[dev]",
"jupyter",
"pytest",
"pytest-cov",
"ruff",
"mypy"
]to [dependency-groups]
dev = [
"bdpy[dev]",
"jupyter",
"pytest",
"pytest-cov",
"ruff",
"mypy"
]
[tool.uv]
default-groups = ["dev"]so that dev dependencies can be installed successfully via uv? I believe the remaining changes are fine, so I’d like to merge them as soon as this fix is reflected. Thank you References |
Co-authored-by: Copilot <copilot@github.com>
|
@ganow |
|
@HirokiYasuda03 thank you! But please not to include uv.lock since this repository is the package |
|
@ganow |
|
@HirokiYasuda03 Thank you! |
Summary
This pull request improves compatibility and documentation for legacy Python versions.
Changes
Related Issue
Closes #111