Skip to content

Fix pyproject.toml for the final release of bdpy supporting Python 3.6–3.8#112

Merged
ganow merged 9 commits into
KamitaniLab:devfrom
HirokiYasuda03:feat/py36+
May 13, 2026
Merged

Fix pyproject.toml for the final release of bdpy supporting Python 3.6–3.8#112
ganow merged 9 commits into
KamitaniLab:devfrom
HirokiYasuda03:feat/py36+

Conversation

@HirokiYasuda03
Copy link
Copy Markdown
Contributor

Summary

This pull request improves compatibility and documentation for legacy Python versions.

Changes

  • Updated installation scripts and dependencies to support Python 3.6–3.8.
  • Added installation instructions in the documentation.
  • Modified GitHub Actions workflow for testing Python 3.6, 3.7

Related Issue

Closes #111

Copy link
Copy Markdown
Contributor

@ganow ganow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've briefly reviewed the PR and added comments. Could you please make revisions based on these comments? I haven't actually tested the proposed changes myself, so please verify whether they work as expected.

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread .github/workflows/test_old.yml Outdated
@HirokiYasuda03
Copy link
Copy Markdown
Contributor Author

I fixed code based on your comment and I think all the pytest passed.
I would appreciate it if you could check my changes.

@ganow
Copy link
Copy Markdown
Contributor

ganow commented May 12, 2026

@HirokiYasuda03 Sorry for not seeing this PR for a long time.

Could you please change the following section of pyproject.toml from

[tool.rye]
managed = true
dev-dependencies = [
    "bdpy[dev]",
    "jupyter",
    "pytest",
    "pytest-cov",
    "ruff",
    "mypy"
]

to

[dependency-groups]
dev = [
    "bdpy[dev]",
    "jupyter",
    "pytest",
    "pytest-cov",
    "ruff",
    "mypy"
]

[tool.uv]
default-groups = ["dev"]

so that dev dependencies can be installed successfully via uv? I believe the remaining changes are fine, so I’d like to merge them as soon as this fix is reflected. Thank you

References

Co-authored-by: Copilot <copilot@github.com>
@HirokiYasuda03
Copy link
Copy Markdown
Contributor Author

HirokiYasuda03 commented May 13, 2026

@ganow
I changed the pyproject.toml and uv.lock.
I think all the tests are passed, but test summery is not uploaded due to permission issue.

@ganow
Copy link
Copy Markdown
Contributor

ganow commented May 13, 2026

@HirokiYasuda03 thank you! But please not to include uv.lock since this repository is the package

@HirokiYasuda03
Copy link
Copy Markdown
Contributor Author

@ganow
Sorry. I deleted the uv.lock.

@ganow
Copy link
Copy Markdown
Contributor

ganow commented May 13, 2026

@HirokiYasuda03 Thank you!

@ganow ganow merged commit b0a45c5 into KamitaniLab:dev May 13, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants