Conversation
Co-authored-by: Copilot <copilot@github.com>
Fix pyproject.toml for the final release of bdpy supporting Python 3.6–3.8
#118) * chore: automatically updated all versions of the GHA packages currently under active development to the latest versions * chore: update pytest-github-actions-annotate-failures to latest version * chore: stop using the chartboost/ruff-action, which is now a public archive, and switch to the official GHA provided by astral-sh * chore: specify not to install pytest-github-actions-annotate-failures v0.3.0 to avoid INTERNALERROR in Python 3.8 and 3.9 * chore: update lint workflow to trigger on dev branch for push and pull requests * [fix] upgrade ruff-action from v3 to v4 to avoid Node.js 20 deprecation warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [fix] update test_old.yml: use ubuntu-22.04 and rename trigger branch to maintenance/legacy - Replace retired ubuntu-20.04 runner with ubuntu-22.04 - Change trigger branch from test_old to maintenance/legacy to clarify intent with a prefix and decouple from specific Python version names Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [fix] pin ruff-action to v4.0.0 as v4 tag does not exist Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
python:3.6-buster container uses sh (dash) as default shell, which does not support 'set -o pipefail'. Explicitly set shell: bash. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* bugfix: fix the behavior of ImageDataset * Bugfix: bdpy/dl/torch/dataset.py * test: add ImageDataset tests and fix auto-detection order Add tests/dl/torch/test_dataset.py with 9 test cases covering CHW axis order, per-channel values, DataLoader integration, value normalization, length, explicit stimulus ordering, and auto-detection via Path.stem. Also sort auto-detected stimulus names for deterministic ordering, and remove the empty TestImageDataset stub from test_torch.py. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> * refactor: remove unused import of torch in test_dataset.py * test: update ImageDataset tests to use PNG format for images * doc: update ImageDataset docstring to clarify stimulus_names behavior and add notes on image format --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
* [fix] Delete deprecated ruff rule * [fix] Update ruff configuration section headers * [fix] Correct exclude directory name in ruff configuration * [update] introduce numpy convention rule in ruff setting * [update] Add 'I' to ruff select rules for improved linting * [fix] Move select/ignore under [tool.ruff.lint] per review Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
@KenyaOtsuka This is mostly a procedural review request required by the repository rules. I would appreciate your approval.
|
KenyaOtsuka
approved these changes
May 18, 2026
Contributor
Author
|
I am withdrawing this PR to preserve commit linearity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backmerge release (now at tag 0.26) into main for the shared Anaconda environment.
Includes PR #98, #99, #100, #101, #103, #105, #109, #112, #118 and the v0.26 release commit.