chore: update GitHub Actions versions and replace archived ruff action#118
Conversation
…ly under active development to the latest versions
…rchive, and switch to the official GHA provided by astral-sh
… v0.3.0 to avoid INTERNALERROR in Python 3.8 and 3.9
KenyaOtsuka
left a comment
There was a problem hiding this comment.
I reviewed the PR and left a couple of comments. Could you please update the PR accordingly?
| - uses: actions/checkout@v6 | ||
| - name: Lint with ruff | ||
| uses: chartboost/ruff-action@v1 | ||
| uses: astral-sh/ruff-action@v3 |
There was a problem hiding this comment.
astral-sh/ruff-action@v3 runs on Node.js 20, and the current GitHub Actions lint job shows a Node.js 20 deprecation warning.
astral-sh/ruff-action@v4 is already available and runs on Node.js 24, so I think we should use v4 instead of v3.
There was a problem hiding this comment.
test_old.yml does not seem to be exercised by the current PR checks.
Could you confirm that this workflow still works as intended after this change?
I am particularly concerned that it still uses ubuntu-20.04, since the GitHub-hosted Ubuntu 20.04 runner image has been retired:
https://github.blog/changelog/2025-01-15-github-actions-ubuntu-20-runner-image-brownout-dates-and-other-breaking-changes/
There was a problem hiding this comment.
Thank you for the suggestion. Addressed in fc17758:
- Replaced
ubuntu-20.04withubuntu-22.04to avoid the retired runner image. - Also renamed the trigger branch from
test_oldtomaintenance/legacy. The prefix clarifies that this branch is for maintaining legacy Python support, and decouples the branch name from specific version numbers (e.g.,feat/py36+looked like a feature branch, and the supported version range may change over time).
The workflow itself has not been run in this PR since it only fires on pushes to the trigger branch. I will verify it works as intended after this PR is merged.
…on warning Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… to maintenance/legacy - Replace retired ubuntu-20.04 runner with ubuntu-22.04 - Change trigger branch from test_old to maintenance/legacy to clarify intent with a prefix and decouple from specific Python version names Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
KenyaOtsuka
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments.
The updates look good to me.
Python 3.8 test is currently failing, but this is not caused by this PR, so I think it is fine.
|
@KenyaOtsuka I confirmed that test_old CI works appropriately in https://github.com/KamitaniLab/bdpy/actions/runs/25806577703 Note that, Please see commit a770e6e for the actual changes. |
Summary
actions/checkoutfrom v3/v4 → v6 andactions/setup-pythonfrom v4 → v6 across all workflows (ci.yml,lint.yml,test_old.yml)chartboost/ruff-action@v1with the officialastral-sh/ruff-action@v3inlint.ymlMishaKav/pytest-coverage-commentfrom v1.1.47 → v1.7.2 and unpinnedpytest-github-actions-annotate-failuresto always use the latest versionBackground
chartboost/ruff-actionis now a public archive and no longer maintained. Continuing to use it risks breakage as the repo will not receive security patches or updates.Test plan
Lint job uses→ The lint job fails, but this is not due to a configuration error in the workflow; it is simply the result of a lint error, so there is no issue.astral-sh/ruff-action@v3without errors