test(screenshot): Phase 3 — Apps, Broker, Language (full screen coverage) - #9
Merged
Merged
Conversation
…age) Complete screen-level Roborazzi coverage using the existing harness: - Promote AppsContent, BrokerContent, LanguageSettingsContent to internal. - Apps (populated/empty), Broker (empty/filled+TLS+connected), Language (system-default/French). 20 baselines total, all 7 screens covered. - Refresh the three promoted-content detekt baseline IDs. - Log Phase 3 + the operational-switch decisions (skip CI-side recording; branch protection is an owner action) in the execution log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 3 of screenshot testing: complete screen-level coverage with the last three screens (Apps, Broker, Language), and settle the two operational switches from the plan. Reuses the existing harness — no new infrastructure.
Follows
docs/screenshot-testing-strategy.md.Changes
AppsContent,BrokerContent,LanguageSettingsContentprivate → internal.LongMethodIDs.Operational switches
verifyRoborazziDebuga required check is a GitHub setting (protectmain→ require the "Build, unit tests, detekt, lint" check).Verified
assembleDebug testDebugUnitTest verifyRoborazziDebug detekt lintDebugall green locally; Broker filled state visually confirmed (real English, populated fields, TLS on).