fix(atomics): retain Windows YARA fixtures until scanning can finish - #55
Merged
Conversation
This was referenced Sep 10, 2026
Merged
This was referenced Sep 11, 2026
Karib0u
added a commit
to Karib0u/rustinel
that referenced
this pull request
Sep 11, 2026
CI pinned 5b8f001, a commit on the unmerged fix/windows-atomic-fixture-lifetime branch, and release pinned c1d78b4, which predates that fix. The fix is now merged as be877b7 (Karib0u/rustinel-rules#55), so both workflows run the same atomic suite from the rules repository's main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows YARA atomics delete their fixture executables immediately after process exit. The asynchronous scanner then reports missing paths and the same three atomics fail on main and engine PR #467.
Keep fixtures available for five seconds after execution, fail on setup errors, and always remove them in a finally block. No detection assertion or failure policy is relaxed.
Validation: all rules CI checks passed, including Linux, macOS, and Windows. All three Windows YARA fixtures now pass; Windows reports 28/29 detections with the existing allowed EICAR miss unchanged. Engine PR Karib0u/rustinel#467 pins this commit and runs its own atomic suite.