[PR] fix(logging): strip compile-time absolute paths from log output - #131
Merged
Conversation
logrus's SetReportCaller embeds the absolute source path baked in at build time, which leaked the build machine's directory layout into logs shipped with the released .exe (issue #130). Add a CallerPrettyfier that rewrites it to a path relative to the project root, computed at runtime from this file's own reported path so it works regardless of how or where the binary was built.
errcheck flagged the unchecked defer logFile.Close() in TestSetLogging_NoAbsoluteBuildPathLeaksIntoLogFile.
Add concurrency groups with cancel-in-progress to the top-level workflows (pipeline, docker_release, cla) so rapid pushes/comments on the same PR, ref, or issue don't race overlapping CI runs. The workflow_call-only reusable workflows (lint, e2e_tests, docker_build_verify, docker_publish) don't need their own group since they run inside the caller's run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logrus's SetReportCaller embeds the absolute source path baked in at build time, which leaked the build machine's directory layout into logs shipped with the released .exe (issue #130). Add a CallerPrettyfier that rewrites it to a path relative to the project root, computed at runtime from this file's own reported path so it works regardless of how or where the binary was built.