Try to be smarter about when to warn for ans files not being accepted - #485
Merged
gkreitz merged 1 commit intoSep 2, 2026
Merged
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
pehrsoderman
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes our warning when
.ansfiles are not accepted by the output validator, in line with what I outlined in #344.When looking at secret test cases, our logic now looks at the validation result across all of them. If the output validator rejects the
.ansfile on all of them, we just do an.info(not shown by default), as this means we're very likely in a scenario where the.ansfile should not look like the output. If some get AC and some don't, we give a (hopefully clear) warning. We only give one warning now, not one per test case.Fixes #344