Fix macro text input cursor reset / マクロ入力のカーソルリセット修正 - #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要(日本語)
Issue #956 を修正します。
原因
マクロ編集画面の「通常テキスト」は入力ごとに
submitListで RecyclerView の行が再バインドされ、EditText.setText()が IME の未確定文字列とカーソル位置をリセットしていました。対応
setTextKeepState()を使用確認
あかさたなの入力、削除、再入力で順序とカーソル位置に問題なしSummary (English)
Root cause
Each edit in the macro editor submitted a new RecyclerView list, causing the normal-text
EditTextto be rebound. CallingsetText()during IME composition reset the composing text and cursor position.Changes
setTextKeepState()for external synchronizationVerification
あかさたな, deletion, and re-entry preserved the expected order and cursor position