Skip to content

Fixing small issues to fix release: KeY 2.12.1#3251

Closed
mattulbrich wants to merge 21 commits into
mainfrom
KeY-2.12.1
Closed

Fixing small issues to fix release: KeY 2.12.1#3251
mattulbrich wants to merge 21 commits into
mainfrom
KeY-2.12.1

Conversation

@mattulbrich
Copy link
Copy Markdown
Member

Some glitches have slipped through for the release 2.12.0.

(branched from KeY-2.12.0)

.key files cannot be edited if they have an error

The "edit file" button does not work if there is a syntax error in a key file to be loaded. Instead the following stacktrace occurred:

Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException: Cannot invoke "String.equals(Object)" because the return value of "java.net.URI.getScheme()" is null
	at de.uka.ilkd.key.gui.actions.EditSourceFileAction.tryGetFile(EditSourceFileAction.java:209)
	at de.uka.ilkd.key.gui.actions.EditSourceFileAction.actionPerformed(EditSourceFileAction.java:283)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1972)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2313)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.plaf.basic.BasicButtonListener.mouseReleased(BasicButtonListener.java:279)
	at java.desktop/java.awt.Component.processMouseEvent(Component.java:6626)

Fixed with b21475e

wadoon added 3 commits August 18, 2023 16:54
* key.core:rifl was moved to key.core.rifl (toplevel)
  due to project naming on Maven Central
@wadoon wadoon self-requested a review August 20, 2023 12:50
@wadoon wadoon added this to the v2.12.1 milestone Aug 20, 2023
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 20, 2023

Thank you for your contribution.

The test artifacts are available on Artiweb.
The newest artifact is here.

FliegendeWurst and others added 8 commits September 5, 2023 08:17
Might be added again later if we agree on its usefulness.
Changes:
- SMT solvers are properly terminated on timeout
- Proof Macro statistics are kept visible and only count the newly
applied rules
- Stop button is disabled after use, re-enabled after stop completes
(this is to avoid double activation)
- Bugfix: fully disable origin tracking if it is disabled
- Bugfix: proof slicing works even if a cut introduced no new formulas
in any branch
- Bugfix: detection of active git branch always refreshes correctly
- Bugfix: when marking goal(s) as interactive/automatic, proof tree no
longer loses expansion state
@wadoon
Copy link
Copy Markdown
Member

wadoon commented Oct 13, 2023

We need to create a new PR because merging is needed and this should not be done on the release branch.
/close

@wadoon wadoon closed this Oct 13, 2023
github-merge-queue Bot pushed a commit that referenced this pull request Oct 13, 2023
Backporting the bug fixes in KEY-2.12.1 to main. This PR supersedes
#3251 to avoid merge conflicts due to file header changes. Necessary
changes were cherry-picked.
@wadoon wadoon deleted the KeY-2.12.1 branch December 30, 2025 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants