Automatically abbreviate anon heap names#3268
Conversation
94763b4 to
64f2358
Compare
Codecov Report
@@ Coverage Diff @@
## main #3268 +/- ##
============================================
- Coverage 37.74% 37.74% -0.01%
Complexity 16851 16851
============================================
Files 2052 2052
Lines 125687 125688 +1
Branches 21234 21234
============================================
Hits 47436 47436
- Misses 72408 72409 +1
Partials 5843 5843
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
|
A rather more general question: Why use abbreviations and not (Skolem) constants which would not only simplify things on the visual surface. For method calls, a fresh heap constants seems to be introduced for every call, could the same not be done for loops too. (The automation has afaik already been optimised for reoccurrences of the same heap symbol) ... Perhaps we should discuss this in person. |
|
A few remarks from our discussion:
|
|
We decided that the solution with abbreviations is not what we want to have, thus I close this PR now. |
By automatically abbreviating heap names, it is much easier to navigate and inspect the sequent view. The screenshots below show the same proof node. Discussion points: Should this option be automatically enabled? Is the naming scheme (
heap_loop_X) fine?Heap names after method calls don't need to be abbreviated, they are already just referred to by "heapAfter_commonEntry" or similar.
This PR builds on top of #3251 and #3258. Only the last five commits in this branch are relevant.