Fix most-recent file not set after loading recent-files list (#3711)#3866
Merged
Conversation
RecentFileMenu.loadFrom updated mostRecentFile only when it was already non-null, and then reassigned it on every iteration. After startup this left mostRecentFile null, so File -> Reload had no (or the wrong) target. Reset mostRecentFile and set it to the first entry of the stored list, which is kept most-recent-first. Created with AI tooling support
unp1
marked this pull request as ready for review
June 27, 2026 10:57
unp1
enabled auto-merge
June 27, 2026 14:59
wadoon
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
This pull request resolves #3711.
Intended Change
RecentFileMenu.loadFromupdatedmostRecentFileonly when it was already non-null,and then reassigned it on every loop iteration. As a result, after startup
mostRecentFilewas leftnull, soFile -> Reload(which usesgetMostRecent()) hadno — or the wrong — target.
The fix resets
mostRecentFileand sets it to the first entry of the stored list, whichis kept most-recent-first.
Note: the in-session "move an already-listed file to the front" behaviour described in
#3711 was already fixed by an earlier refactor of
addRecentFileNoSave; this PR addressesthe remaining startup case.
Type of pull request
Ensuring quality
RecentFileMenuTest.mostRecentIsFirstEntryAfterLoad,a headless test that writes a recent-files store (via the same
Configuration.ConfigurationWriterthe app uses), loads it, and asserts
getMostRecent()is the first entry. Verified it failswithout the fix (
expected A.key but was null) and passes with it. Ran./gradlew :key.ui:test --tests "de.uka.ilkd.key.gui.RecentFileMenuTest".Additional information and contact(s)
PR created with AI tooling support
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.