Taclet match dialog: readable \assumes candidates and smarter window placement#3882
Merged
Merged
Conversation
…placement Two minor usability fixes to the redesigned taclet-match dialog: - Selecting (rather than typing) an \assumes instantiation: a candidate sequent formula that the pretty-printer wraps across several lines was rendered with only its first physical line, so a wrapped formula showed a short stub (or nothing, when it began with a newline) followed by blank space, and abbreviated far too early. The candidate now flattens the whole formula to one line (TmText.collapseToLine, which also collapses the printer's alignment indentation and trims), and the abbreviation limit is raised 100 -> 200 so more of the formula is visible before the ellipsis. Full text remains on hover. - Window placement: the dialog was centred over the main window, so it covered the sequent view the user needs for reading variable names and dragging sub-terms onto fields. It now auto-places itself beside the sequent view (right, else left, else the roomier screen edge, always fully on screen), and reuses the last position the user moved it to for the rest of the session. The position is intentionally not persisted across restarts, where the main window may sit elsewhere; the window size is still persisted as before. feature/taclet-match-dialog-minor-improvements
unp1
force-pushed
the
feature/taclet-match-dialog-minor-improvements
branch
from
July 1, 2026 19:19
e5afba0 to
4f3bbb8
Compare
unp1
marked this pull request as ready for review
July 1, 2026 19:35
unp1
enabled auto-merge
July 1, 2026 19:35
wadoon
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intended Change
Two usability fixes to the redesigned taclet-match dialog.
1. Readable
\assumescandidates in "Select from sequent" mode.When picking (rather than typing) an
\assumesinstantiation, each candidatesequent formula was rendered with only its first physical line. A formula that
the pretty-printer wraps across several lines therefore showed a short stub — or
nothing at all, when it began with a newline, followed by blank space, and it
abbreviated far too early. The candidate now flattens the whole formula onto one
line, and the abbreviation limit is raised from 100
to 200 characters so more of the formula is visible before the ellipsis. The
full formula remains available on hover.
2. Smarter window placement.
The dialog was centred over the main window (
setLocationRelativeTo), so itcovered the sequent view, exactly what the user needs in order to read a
variable name or drag a sub-term onto a field. It now auto-places itself beside
the sequent view: to the right if there is room, else to the left, else docked
to the roomier screen edge, always fully on screen. Within a session it reuses
the last position the user moved it to. The position is intentionally not
persisted across restarts (where the main window may sit elsewhere, a stale
absolute position would be worse than a fresh placement); the window size is
still persisted as before.
Type of pull request
Ensuring quality
TmTextTest.collapseToLinenow covers wrapped-formula indentation and trimming).:key.uicompiles and passes spotless; thede.uka.ilkd.key.gui.tacletmatch.*test suite is green. Manually verified that a multi-line\assumescandidate now reads as one line, and that the dialog opens beside the sequent view instead of on top of it (and reopens where it was last moved).Additional information and contact(s)
Follow-up polish on top of the redesigned taclet-match dialog. Both changes are
confined to the
de.uka.ilkd.key.gui.tacletmatchpackage.Created with AI tooling support
The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.